Attention is currently required from: daniel, fixeria.
Patch set 2:Code-Review +1
View Change
1 comment:
Patchset:
Patch Set #2:
I had the same idea and wasn't yet 100% sure. But I would agree, just break and log, but as long it is only an unknown type, try to process and fails later when missing some mandatory TLVs.
To view, visit change 38835. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I341565cb932d30d953ebd27d6b87f930cd8fa229
Gerrit-Change-Number: 38835
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: daniel <dwillmann@sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Nov 2024 13:42:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes