10 Aug
2024
10 Aug
'24
6:57 a.m.
Attention is currently required from: fixeria, laforge.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37727?usp=email )
Change subject: Makefile: add 'install' target, clean up debian/rules ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Patchset:
PS2: nice!
File Makefile:
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37727/comment/8419fd96_f... : PS2, Line 29: install -m 0644 contrib/systemd/osmo_dia2gsup.service $(DESTDIR)$(SYSTEMDUNITDIR) If you use -D, then install will create the directory, e.g.:
```suggestion install -Dm 0644 contrib/systemd/osmo_dia2gsup.service $(DESTDIR)$(SYSTEMDUNITDIR) ```
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37727?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo_dia2gsup
Gerrit-Branch: master
Gerrit-Change-Id: I0769ca5f922a41f2b0976bf283176040aae4c781
Gerrit-Change-Number: 37727
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Mon, 05 Aug 2024 07:39:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes