Attention is currently required from: fixeria, laforge.
Patch set 2:Code-Review +1
View Change
2 comments:
Patchset:
File Makefile:
Patch Set #2, Line 29: install -m 0644 contrib/systemd/osmo_dia2gsup.service $(DESTDIR)$(SYSTEMDUNITDIR)
If you use -D, then install will create the directory, e.g.:
```suggestion
install -Dm 0644 contrib/systemd/osmo_dia2gsup.service $(DESTDIR)$(SYSTEMDUNITDIR)
```
To view, visit change 37727. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo_dia2gsup
Gerrit-Branch: master
Gerrit-Change-Id: I0769ca5f922a41f2b0976bf283176040aae4c781
Gerrit-Change-Number: 37727
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Aug 2024 07:39:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes