Attention is currently required from: jolly, laforge, fixeria.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30762 )
Change subject: isdn: Add V.110 encoder/decoder ......................................................................
Patch Set 10: Code-Review+1
(4 comments)
Patchset:
PS10: Looks good to me, except the missing/incomplete doxygen documentation.
File src/isdn/v110.c:
https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/01f928e4_68a9f42c PS10, Line 14: /* (C) 2022 by Harald Welte laforge@osmocom.org Missing license header.
https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/aee0ce0b_beecf9ee PS10, Line 30: \param[out] caller-allocated `\param[out] fr ...`
https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/705f54b4_b9f4bdce PS10, Line 31: * \param[in] ra_bits One V.110 frame as 80 unpacked bits. */ Missing `\param` for `n_bits`, also missing `\returns`.