Attention is currently required from: jolly, laforge, fixeria.

Patch set 10:Code-Review +1

View Change

4 comments:

• Patchset:

  • Patch Set #10:

    Looks good to me, except the missing/incomplete doxygen documentation.

• File src/isdn/v110.c:

  • Patch Set #10, Line 14: /* (C) 2022 by Harald Welte <laforge@osmocom.org>

    Missing license header.

  • Patch Set #10, Line 30: \param[out] caller-allocated

    `\param[out] fr ...`

  • Patch Set #10, Line 31: * \param[in] ra_bits One V.110 frame as 80 unpacked bits. */

    Missing `\param` for `n_bits`, also missing `\returns`.

To view, visit change 30762. To unsubscribe, or for help writing mail filters, visit settings.