Attention is currently required from: daniel, dexter, fixeria, pespin.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34445?usp=email )
Change subject: ipa: Don't break strict aliasing rule ......................................................................
Patch Set 2:
(2 comments)
File include/osmocom/netif/ipa.h:
https://gerrit.osmocom.org/c/libosmo-netif/+/34445/comment/817e0602_645e0b44 PS2, Line 26: #warning "OSMO_IPA_MSGB_CB breaks the strict aliasing rule. Don't use unless -fno-strict-aliasing flag is enabled!"
I just tried to build libosmo-netif completely and I don't see any warning nor error.
I'm not sure if getting no warning from gcc is always equivalent with gcc not making use of, say strict aliasing optimizations. I wouldn't trust gcc that far. I have used the second solution you suggested above.
File include/osmocom/netif/ipa.h:
https://gerrit.osmocom.org/c/libosmo-netif/+/34445/comment/e47f3910_a116c0ab PS1, Line 21: osmo_ipa_msgb_cb
Is this warning going to show up when compiling any files including this header and not necessarily […]
(not a problem anymore, since the newest patch version is aliasing with a union in a legal way)