Attention is currently required from: daniel, dexter, fixeria, pespin.

View Change

2 comments:

• File include/osmocom/netif/ipa.h:

  • Patch Set #2, Line 26: #warning "OSMO_IPA_MSGB_CB breaks the strict aliasing rule. Don't use unless -fno-strict-aliasing flag is enabled!"

    I just tried to build libosmo-netif completely and I don't see any warning nor error.

    I'm not sure if getting no warning from gcc is always equivalent with gcc not making use of, say strict aliasing optimizations. I wouldn't trust gcc that far. I have used the second solution you suggested above.

• File include/osmocom/netif/ipa.h:

  • Patch Set #1, Line 21: osmo_ipa_msgb_cb

    Is this warning going to show up when compiling any files including this header and not necessarily […]

    (not a problem anymore, since the newest patch version is aliasing with a union in a legal way)

To view, visit change 34445. To unsubscribe, or for help writing mail filters, visit settings.