13 Aug
2024
13 Aug
'24
12:51 p.m.
Attention is currently required from: fixeria, laforge.
jolly has posted comments on this change by jolly. (
https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email )
Change subject: After writing VTY config, run sync() in a different thread
......................................................................
Patch Set 2:
(6 comments)
Patchset:
PS2:
If we only care about the new file (not to the
backup), it is straight forward to implement with fsy […]
Done
PS2:
the question is do we really care about the thread
creation overhead for something that happens as r […]
To avoid the delay problems,
we don't want any write to delay the process. If the thread creation overhead is less
than one millisecond, I don't see any problem.
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/37798/comment/86d11e74_2122bb1d?… :
PS2, Line 10: results
typo: result (without 's')
Done
https://gerrit.osmocom.org/c/libosmocore/+/37798/comment/9cdce0b8_60afcab8?… :
PS2, Line 11: delays
delayed processing causes ... and s/delays/timeouts/?
[…]
Done
https://gerrit.osmocom.org/c/libosmocore/+/37798/comment/41833c6a_ed45b798?… :
PS2, Line 16: The main process will then output the completion
: message on the VTY.
This is no longer true, we decided to log an INFO
instead.
Done
File src/vty/command.c:
https://gerrit.osmocom.org/c/libosmocore/+/37798/comment/e687b8df_fd115284?… :
PS2, Line 3413: sync();
: sync_complete(&sync_fd, 0);
:
common path for all failing checks, maybe move it down
below to the bottom and use `goto`?
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44
Gerrit-Change-Number: 37798
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Hoernchen <ewild(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Aug 2024 10:51:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>