Attention is currently required from: Hoernchen, laforge, osmith, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41660?usp=email )
Change subject: bts-trx: define TRXD_MSG_BUF_SIZE as a more realistic lower value ......................................................................
Patch Set 6:
(4 comments)
File src/osmo-bts-trx/trx_if.h:
https://gerrit.osmocom.org/c/osmo-bts/+/41660/comment/18526a80_411107bd?usp=... : PS6, Line 7: NOTE: a legacy transceiver may append two garbage bytes. This is only relevant for Uplink TRXDv0 PDUs, see my suggestion `a)` below.
https://gerrit.osmocom.org/c/osmo-bts/+/41660/comment/118684d6_82aa9305?usp=... : PS6, Line 16: TRXD_UL_V2HDR_LEN Note that size of optional TDMA Fn is not included here (it is also not included in the original `TRX_UL_V2HDR_LEN` because it's the minimum length). See how `trx_data_handle_pdu_v2()` is returning `TRX_UL_V2HDR_LEN + sizeof(bi->fn)`. See my suggestion `b)` below.
https://gerrit.osmocom.org/c/osmo-bts/+/41660/comment/90ef670d_5ce13794?usp=... : PS6, Line 17: TRXD_UL_V0HDR_LEN Suggestion `a)`: `TRXD_UL_V0HDR_LEN + 2` to account for two garbage bytes. Suggestion `b)`: `TRXD_UL_V2HDR_LEN + 4` to account for optional TDMA Fn field.
File src/osmo-bts-trx/trx_if.h:
https://gerrit.osmocom.org/c/osmo-bts/+/41660/comment/5ad31265_0d2f76c5?usp=... : PS3, Line 12: TRXD_BURST_SIZE_MAX * TRX_NR_TS
Ack, I'll add some extra bytes for the header.
Done