Attention is currently required from: Hoernchen, laforge, osmith, pespin.

View Change

4 comments:

• File src/osmo-bts-trx/trx_if.h:

  • Patch Set #6, Line 7: NOTE: a legacy transceiver may append two garbage bytes.

    This is only relevant for Uplink TRXDv0 PDUs, see my suggestion `a)` below.

  • Patch Set #6, Line 16: TRXD_UL_V2HDR_LEN

    Note that size of optional TDMA Fn is not included here (it is also not included in the original `TRX_UL_V2HDR_LEN` because it's the minimum length). See how `trx_data_handle_pdu_v2()` is returning `TRX_UL_V2HDR_LEN + sizeof(bi->fn)`. See my suggestion `b)` below.

  • Patch Set #6, Line 17: TRXD_UL_V0HDR_LEN

    Suggestion `a)`: `TRXD_UL_V0HDR_LEN + 2` to account for two garbage bytes.
    Suggestion `b)`: `TRXD_UL_V2HDR_LEN + 4` to account for optional TDMA Fn field.

• File src/osmo-bts-trx/trx_if.h:

  • Patch Set #3, Line 12: TRXD_BURST_SIZE_MAX * TRX_NR_TS

    Ack, I'll add some extra bytes for the header.

    Done

To view, visit change 41660. To unsubscribe, or for help writing mail filters, visit settings.