15 Feb
2025
15 Feb
'25
11:39 p.m.
Attention is currently required from: daniel, laforge, neels, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email )
Change subject: vlr: add PS support
......................................................................
Patch Set 6:
(5 comments)
File src/libvlr/vlr_lu_fsm.c:
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/ce929dee_04b1d31b?usp… :
PS5, Line 587: return 1;
Agree
Done
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/2d4161d8_74395881?usp… :
PS5, Line 598: break;
yeah makes sense having an ASSERT which should hit
indicating some timeout was forgotten to be added […]
Done
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/f88cac26_765b45a5?usp… :
PS5, Line 1570: {
(would be nice to have a short one-liner comment to
indicate what this does / why it needs to go in […]
I replaced the preterm and
moved it into the timer_cb.
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/9fa5cb4d_a97ea383?usp… :
PS5, Line 1586: gsm48_cause = GSM48_REJECT_NETWORK_FAILURE;
(add "break;" in the end)
Done
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/ea27908f_124cd4d0?usp… :
PS5, Line 1742:
(two blank lines, unusual for osmocom)
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0
Gerrit-Change-Number: 38490
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 15 Feb 2025 22:39:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>