Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30523 )
Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload ......................................................................
Patch Set 3:
(3 comments)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/30523/comment/c391ed94_9c509326 PS3, Line 1260: if (lchan->tch_mode == GSM48_CMODE_SPEECH_V1 && lchan->type == GSM_LCHAN_TCH_H) { You could do a switch (lchan->tch_mode) together with the block above.
https://gerrit.osmocom.org/c/osmo-bts/+/30523/comment/b61143e3_221dbae0 PS3, Line 1915: * reception depending on what the particular BTS model supports. In case no preference is set, it will be I'd go for explicitly setting supported values in each bts_model, and avoid code paths where we end up sending god knows what to the lower layers.
This also means the code block below can be structured a bit (right now it's quite messy with large conditions difficult to follow without early returns).
https://gerrit.osmocom.org/c/osmo-bts/+/30523/comment/9d79108b_05f7441e PS3, Line 1924: * byte TOC header in frond of the audio payload. (See also: RFC 5993, section 5.2) */ typo: front