Attention is currently required from: fixeria, dexter.

View Change

3 comments:

• File src/common/l1sap.c:

  • Patch Set #3, Line 1260: if (lchan->tch_mode == GSM48_CMODE_SPEECH_V1 && lchan->type == GSM_LCHAN_TCH_H) {

    You could do a switch (lchan->tch_mode) together with the block above.

  • Patch Set #3, Line 1915: * reception depending on what the particular BTS model supports. In case no preference is set, it will be

    I'd go for explicitly setting supported values in each bts_model, and avoid code paths where we end up sending god knows what to the lower layers.

    This also means the code block below can be structured a bit (right now it's quite messy with large conditions difficult to follow without early returns).

  • Patch Set #3, Line 1924: * byte TOC header in frond of the audio payload. (See also: RFC 5993, section 5.2) */

    typo: front

To view, visit change 30523. To unsubscribe, or for help writing mail filters, visit settings.