Change in osmo-hnbgw[master]: fix possible leak of ue_context on UE REGISTER error

Attention is currently required from: neels, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31016 ) Change subject: fix possible leak of ue_context on UE REGISTER error ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/osmo-hnbgw/hnbgw_hnbap.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/31016/comment/2cf3d465_4ec80082 PS1, Line 335: ue = ue_allocated = ue_context_alloc(hnb, NULL, tmsi); Probably to distinguish later that the ue was locally allocated rather than pulled from the context using ui_context_by_tmsi? https://gerrit.osmocom.org/c/osmo-hnbgw/+/31016/comment/a333592b_59579475 PS1, Line 345: ue_context_free(ue_allocated); here: what if hnbap_encode_uregisteraccpties() failes, when the context was from ue_context_by_tmsi() then we keep it when we allocated it above, then we free it. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31016 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Icf4b82f9a904d56332c567f7ccfb24231ee66270 Gerrit-Change-Number: 31016 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Jan 2023 14:31:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment