Attention is currently required from: neels, pespin.

Patch set 1:Code-Review +1

View Change

2 comments:

• File src/osmo-hnbgw/hnbgw_hnbap.c:

  • Patch Set #1, Line 335: ue = ue_allocated = ue_context_alloc(hnb, NULL, tmsi);

    what's the point in having 2 different variables here? I see no benefit and added complexity.

    Probably to distinguish later that the ue was locally allocated rather than pulled from the context using ui_context_by_tmsi?

  • Patch Set #1, Line 345: ue_context_free(ue_allocated);

    here: what if hnbap_encode_uregisteraccpties() failes, when the context was from ue_context_by_tmsi() then we keep it when we allocated it above, then we free it.

To view, visit change 31016. To unsubscribe, or for help writing mail filters, visit settings.