Change in libosmo-sccp[master]: SS7: do not attempt transfer if AS is down

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31295 ) Change subject: SS7: do not attempt transfer if AS is down ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo_ss7_hmrt.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/31295/comment/7e7cfb15_839e3ed6 PS1, Line 232: LOGP(DLSS7, LOGL_ERROR, "The AS %s is down\n", as->cfg.name); I think the log line could benefit from some context like "canout route" or "cannot send packet" or whatever. For a debug message like above/below, I think it's fine. but for an error message intended for the "casual" user, I think it's best to be more descriptive about why we're logging the message "AS is down" right now. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31295 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0d5f3b6265e7fdaa79e32fbc30f829ef79e7dad1 Gerrit-Change-Number: 31295 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Feb 2023 16:41:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment