Attention is currently required from: jolly, laforge.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email )
Change subject: Add multiple messages buffers to struct iofd_msghdr ......................................................................
Patch Set 5:
(3 comments)
File src/core/osmo_io.c:
https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/b1b2e4c3_37cca0ee?u... : PS5, Line 727: iofd->io_buffers = (g_io_backend == OSMO_IO_BACKEND_IO_URING) ? g_io_uring_iov : 1; sounds like we want to have this per-backend logic as part of the per-backend ops, and not here.
File src/core/osmo_io_internal.h:
https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/2baf7e2c_71b350ea?u... : PS5, Line 143: int io_len; I wonder whether this is needed or can be inferred when needed by looking up NULL ptrs in "msg" field below.
File src/core/osmo_io_internal.h:
https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/a767b7c9_568dd343?u... : PS3, Line 140: int msg_max;
According to the note (https://projects.osmocom. […]
This should definetly be configurable over API per osmo_iofd object. Then apps can decide what to use on per socket/interface based.