Attention is currently required from: jolly, laforge.

View Change

3 comments:

• File src/core/osmo_io.c:

  • Patch Set #5, Line 727: iofd->io_buffers = (g_io_backend == OSMO_IO_BACKEND_IO_URING) ? g_io_uring_iov : 1;

    sounds like we want to have this per-backend logic as part of the per-backend ops, and not here.

• File src/core/osmo_io_internal.h:

  • Patch Set #5, Line 143: int io_len;

    I wonder whether this is needed or can be inferred when needed by looking up NULL ptrs in "msg" field below.

• File src/core/osmo_io_internal.h:

  • Patch Set #3, Line 140: int msg_max;

    According to the note (https://projects.osmocom. […]

    This should definetly be configurable over API per osmo_iofd object. Then apps can decide what to use on per socket/interface based.

To view, visit change 40491. To unsubscribe, or for help writing mail filters, visit settings.