15 May
2025
15 May
'25
4:25 p.m.
Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email )
Change subject: Introduce tests/osmo-config-merge testsuite
......................................................................
Patch Set 4:
(6 comments)
File tests/osmo-config-merge/Makefile.am:
https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/6944e778_68ec345b?… :
PS4, Line 25: } >'$(srcdir)/package.m4'
What do we need package.m4 for?
https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/09c8c254_20aeb22f?… :
PS4, Line 46: [ -e /proc/cpuinfo ] && cat /proc/cpuinfo
This is already done in tests/Makefile.am, so I would remove it here.
https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/c5a9850a_f208585d?… :
PS4, Line 47: $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS)
ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS)
```suggestion
$(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS)
```
https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/d1a71072_698b27d1?… :
PS4, Line 51: $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING)
ENABLE_URING_TESTS=$(ENABLE_URING_TESTS)
```suggestion
$(TESTSUITEFLAGS)
```
File tests/osmo-config-merge/atlocal.in:
PS4:
do we need this empty file?
File tests/osmo-config-merge/testA.ok:
https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/f755bf44_dfefc29a?… :
PS4, Line 74: power-ramp step-size 8000 mdB
: power-ramp step-interval 1
: phy 0 instance 0
: power-ramp step-size 2000 mdB
is this correct? I would have expected that the new power-ramp step-size overwrites the
previous one
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia172d4c280f4bae1b411ad805cca02355ca7fcc9
Gerrit-Change-Number: 40295
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 15 May 2025 14:25:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No