24 Jan
2024
24 Jan
'24
7:31 p.m.
Attention is currently required from: fixeria, jolly, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35572?usp=email )
Change subject: Add logging category for libosmo-cc
......................................................................
Patch Set 3:
(1 comment)
File include/osmocom/core/logging.h:
https://gerrit.osmocom.org/c/libosmocore/+/35572/comment/9a99b8db_dfecfea3
PS2, Line 158: #defin
Well, OSMO_NUM_DLIB is a special value reflecting the
total number of those global l-categories. It would be weird if anyone expected this value
to remain constant, and even more weird if it's used anywhere else than in
libosmocore.git.
Then it should be dropped from the public header file (and mark API breakage), unless we
agree we can tell for sure nobody ever used it ourside of libosmocore.
I'm not saying we should unconditionally go for the dynamic API, I was just putting
the different pros/cons on the table.
I think in general this system where libraries on top of libosmocore willing to use new
log categories need to add new code in libosmocore is totally unsustainable in time and
pollutes libosmocore "core" with lots of stuff which is not "core" in
any way.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35572?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9df433b2cfb51f04dbf16e9f8dee567a59ab5cb7
Gerrit-Change-Number: 35572
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 24 Jan 2024 18:31:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment