Attention is currently required from: fixeria, jolly, laforge.

View Change

1 comment:

• File include/osmocom/core/logging.h:

  • Patch Set #2, Line 158: #defin

    Well, OSMO_NUM_DLIB is a special value reflecting the total number of those global l-categories. It would be weird if anyone expected this value to remain constant, and even more weird if it's used anywhere else than in libosmocore.git.

    Then it should be dropped from the public header file (and mark API breakage), unless we agree we can tell for sure nobody ever used it ourside of libosmocore.

    I'm not saying we should unconditionally go for the dynamic API, I was just putting the different pros/cons on the table.
    I think in general this system where libraries on top of libosmocore willing to use new log categories need to add new code in libosmocore is totally unsustainable in time and pollutes libosmocore "core" with lots of stuff which is not "core" in any way.

To view, visit change 35572. To unsubscribe, or for help writing mail filters, visit settings.