Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33692 )
Change subject: pySim/cards: Add type annotations ......................................................................
Patch Set 4:
(4 comments)
File pySim/cards.py:
https://gerrit.osmocom.org/c/pysim/+/33692/comment/e47574b2_734ddd41 PS4, Line 39: reset Missing return type annotation. Something like `-> Optional[...]` I guess?
https://gerrit.osmocom.org/c/pysim/+/33692/comment/17002143_08d37582 PS4, Line 47: set_apdu_parameter Functions returning nothing should be annotated as such using `-> None`.
https://gerrit.osmocom.org/c/pysim/+/33692/comment/73d3902d_9be8ec80 PS4, Line 124: Hexstr `-> Optional[Hexstr]`
https://gerrit.osmocom.org/c/pysim/+/33692/comment/8dafc4b4_68299393 PS4, Line 134: Hexstr `-> Optional[Hexstr]`