Attention is currently required from: jolly.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008?usp=email )
Change subject: Add templates for S1AP Handover procedure ......................................................................
Patch Set 1:
(9 comments)
File library/s1ap/S1AP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/935097f3_ab1f0... : PS1, Line 2293: procedureCode := S1AP_Constants.id_HandoverPreparation, Are you sure this ID is correct?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/3b756f6b_6df5b... : PS1, Line 2337: procedureCode := S1AP_Constants.id_HandoverPreparation, Are you sure this ID is correct?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/d32ecbda_eb4b0... : PS1, Line 2370: } (FYI, see in https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40985/2/library/ranap/RANAP_... an example on how to add optional IEs to the list here).
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/409a6437_eabdb... : PS1, Line 2374: ts_E_RABSubjecttoDataForwardingList(template (value) E_RABDataForwardingItem it) := { IMHO it's better to have a template for E_RABSubjecttoDataForwardingItem, and then simply do "{ ts_E_RABSubjecttoDataForwardingList(...) }" wherever needed.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/dead07bc_5f818... : PS1, Line 2391: template (omit) TransportLayerAddress dl_tla, we usually set default value to ":= omit" for "template (omit)".
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/ac6ac93b_c4a31... : PS1, Line 2423: successfulOutcome := { Are you sure the HandoverCmd is a succesfulOutcome and not an InitialMessage? I'd suggest you revisit the specs and asn1 files.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/b76727f0_f8015... : PS1, Line 2424: procedureCode := S1AP_Constants.id_HandoverPreparation, Are you sure this ID is correct?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/261ca2fc_dc6c2... : PS1, Line 2462: procedureCode := S1AP_Constants.id_HandoverPreparation, same comments as per ts_S1AP_HandoverCmd apply here too.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/bd527db8_babec... : PS1, Line 2560: procedureCode := S1AP_Constants.id_HandoverResourceAllocation, are you sure this ID is correct?