Attention is currently required from: jolly.
9 comments:
File library/s1ap/S1AP_Templates.ttcn:
Patch Set #1, Line 2293: procedureCode := S1AP_Constants.id_HandoverPreparation,
Are you sure this ID is correct?
Patch Set #1, Line 2337: procedureCode := S1AP_Constants.id_HandoverPreparation,
Are you sure this ID is correct?
(FYI, see in https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40985/2/library/ranap/RANAP_Templates.ttcn an example on how to add optional IEs to the list here).
Patch Set #1, Line 2374: ts_E_RABSubjecttoDataForwardingList(template (value) E_RABDataForwardingItem it) := {
IMHO it's better to have a template for E_RABSubjecttoDataForwardingItem, and then simply do "{ ts_E_RABSubjecttoDataForwardingList(...) }" wherever needed.
Patch Set #1, Line 2391: template (omit) TransportLayerAddress dl_tla,
we usually set default value to ":= omit" for "template (omit)".
Patch Set #1, Line 2423: successfulOutcome := {
Are you sure the HandoverCmd is a succesfulOutcome and not an InitialMessage?
I'd suggest you revisit the specs and asn1 files.
Patch Set #1, Line 2424: procedureCode := S1AP_Constants.id_HandoverPreparation,
Are you sure this ID is correct?
Patch Set #1, Line 2462: procedureCode := S1AP_Constants.id_HandoverPreparation,
same comments as per ts_S1AP_HandoverCmd apply here too.
Patch Set #1, Line 2560: procedureCode := S1AP_Constants.id_HandoverResourceAllocation,
are you sure this ID is correct?
To view, visit change 41008. To unsubscribe, or for help writing mail filters, visit settings.