[L] Change in osmocom-bb[master]: mobile: add support for Circuit Switched Data calls

Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34762?usp=email ) Change subject: mobile: add support for Circuit Switched Data calls ...................................................................... Patch Set 6: Code-Review+1 (2 comments) File src/host/layer23/include/osmocom/bb/common/settings.h: https://gerrit.osmocom.org/c/osmocom-bb/+/34762/comment/1d57b3ed_b978df98 PS6, Line 101: enum data_call_ce { what is 'ce' mean in this context? I'd appreciate at least a comment above the enum to explain that. thanks! (I later read below in the VTY that it's the "connection element", but still a comment here would be nice). File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34762/comment/bca320bc_1a0cd125 PS6, Line 379: LOGP(DRR, LOGL_ERROR, at first sigt it looks like trhose lines don't need to be wrapped within 120chars? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34762?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1995fa0a7a68d9b980852b664d472d4633777ac6 Gerrit-Change-Number: 34762 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Oct 2023 08:44:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment