Attention is currently required from: fixeria, jolly.

Patch set 6:Code-Review +1

View Change

2 comments:

• File src/host/layer23/include/osmocom/bb/common/settings.h:

  • Patch Set #6, Line 101: enum data_call_ce {

    what is 'ce' mean in this context? I'd appreciate at least a comment above the enum to explain that. thanks! (I later read below in the VTY that it's the "connection element", but still a comment here would be nice).

• File src/host/layer23/src/mobile/gsm48_rr.c:

  • Patch Set #6, Line 379: LOGP(DRR, LOGL_ERROR,

    at first sigt it looks like trhose lines don't need to be wrapped within 120chars?

To view, visit change 34762. To unsubscribe, or for help writing mail filters, visit settings.