pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795 )
Change subject: mgw_fsm: add MGW support to osmo-hnbgw ......................................................................
Patch Set 1:
(3 comments)
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/1/src/osmo-hnbgw/hnbgw_vty.c File src/osmo-hnbgw/hnbgw_vty.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/1/src/osmo-hnbgw/hnbgw_vty.c... PS1, Line 451: g_hnb_gw->config.mgcp_client = talloc_zero(tall_hnb_ctx, struct mgcp_client_conf); This doesn't look like the proper place to do this. Please move this to the g_hnb_gw alloc function.
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/1/src/osmo-hnbgw/mgw_fsm.c File src/osmo-hnbgw/mgw_fsm.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/1/src/osmo-hnbgw/mgw_fsm.c@8... PS1, Line 84: /* We have to store the RANAP RAB AssignmentRequest message, since we can not take ownership of the osmo prim why can't you take ownsership? is it freed by the callback caller? If not, talloc_steal, if yes, msgb_copy.
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/1/src/osmo-hnbgw/mgw_fsm.c@4... PS1, Line 420: .in_event_mask = S(MGW_EV_MGCP_OK) | S(MGW_EV_MGCP_FAIL), I find it much more clear having one per line, but OK.