View Change

3 comments:

• File src/osmo-hnbgw/hnbgw_vty.c:

  • Patch Set #1, Line 451: g_hnb_gw->config.mgcp_client = talloc_zero(tall_hnb_ctx, struct mgcp_client_conf);

    This doesn't look like the proper place to do this. Please move this to the g_hnb_gw alloc function.

• File src/osmo-hnbgw/mgw_fsm.c:

  • Patch Set #1, Line 84: /* We have to store the RANAP RAB AssignmentRequest message, since we can not take ownership of the osmo prim

    why can't you take ownsership? is it freed by the callback caller? If not, talloc_steal, if yes, msgb_copy.

  • Patch Set #1, Line 420: .in_event_mask = S(MGW_EV_MGCP_OK) | S(MGW_EV_MGCP_FAIL),

    I find it much more clear having one per line, but OK.

To view, visit change 26795. To unsubscribe, or for help writing mail filters, visit settings.