Attention is currently required from: laforge, pespin.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41140?usp=email )
Change subject: Add CAS channel support ......................................................................
Patch Set 4:
(2 comments)
File include/osmocom/abis/e1_input.h:
https://gerrit.osmocom.org/c/libosmo-abis/+/41140/comment/ce28bb03_f296d3d7?... : PS2, Line 197: int (*set_cas)(struct e1inp_ts *ts, uint8_t bits, bool query_rx);
You are breaking ABI here, see: […]
Done
https://gerrit.osmocom.org/c/libosmo-abis/+/41140/comment/63d5c5bc_b2f4d14c?... : PS2, Line 414: uint8_t cas;
ABI break, you must at least put this at the end of the struct and mention it in TODO-RELEASE, see a […]
Done