Attention is currently required from: laforge, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41140?usp=email ) Change subject: Add CAS channel support ...................................................................... Patch Set 4: (2 comments) File include/osmocom/abis/e1_input.h: https://gerrit.osmocom.org/c/libosmo-abis/+/41140/comment/ce28bb03_f296d3d7?... : PS2, Line 197: int (*set_cas)(struct e1inp_ts *ts, uint8_t bits, bool query_rx);
You are breaking ABI here, see: […] Done
https://gerrit.osmocom.org/c/libosmo-abis/+/41140/comment/63d5c5bc_b2f4d14c?... : PS2, Line 414: uint8_t cas;
ABI break, you must at least put this at the end of the struct and mention it in TODO-RELEASE, see a […] Done
-- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I81cc89e01bb4207dc899ab28f24a131f24b61c9c Gerrit-Change-Number: 41140 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Sun, 01 Feb 2026 12:47:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>