Attention is currently required from: laforge.
neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39744?usp=email )
Change subject: [4/6] personalization: refactor Pin, Adm ......................................................................
Patch Set 4:
(1 comment)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/39744/comment/6ef7717e_f3b9e05f?usp=ema... : PS3, Line 408: return (pe for pe in l if pe.type == wanted_type)
- I think from an ISO7816 and UICC point of view it's sadly not correct to limit to MF. […]
This patch is trying to not modify prior behavior. The aim is to remove code dup between class Pin and class AppPin.
- Prior code happens to limit to MF for PIN1. - Prior API happens to produce a mix of ProfileElementList and plain py lists.
If these prior conditions are wrong, I would like to fix them outside of this patch.
I created issue https://osmocom.org/issues/6770 for the MF question. and https://osmocom.org/issues/6771 for the lists question.