12 Jan
2022
12 Jan
'22
12:24 p.m.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890 )
Change subject: bsc: Fix test TC_rll_sapi_n_reject_dlci_cc expectancies
......................................................................
Patch Set 1:
Patch Set 1:
Given that we don't know the origin of the ERROR INDication (whether it's coming
from the MS, or the BTS itself), both GSM0808_CAUSE_{MS,BSS}_NOT_EQUIPPED values are kind
of valid. My proposal is to expect either of the two possible values:
f_exp_sapi_n_reject(3, (GSM0808_CAUSE_BSS_NOT_EQUIPPED,
GSM0808_CAUSE_MS_NOT_EQUIPPED), '10'B);
After all, what we want to verify here is the 'Control Channel type' bits.
Using that kind of templates gives a lot side effect problems because of call:
f_exp_sapi_n_reject() -> tr_BSSMAP_IE_Cause() -> f_tr_causeValue(), which then fails
when resolving the value (due to not being "?"):
Dynamic test case error: Performing a valueof or send operation on a non-specific template
of enumerated type @BSSMAP_Templates.myBSSMAP_Cause.
So I'm keeping the patch as is, since anyway we also use this same value in another
test.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26890
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ieebe3465b31d98fcae0e2c1993477c5021c99b3b
Gerrit-Change-Number: 26890
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Jan 2022 12:24:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment