Change in osmo-ttcn3-hacks[master]: add library/PFCP_*, deps/PFCP

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 ) Change subject: add library/PFCP_*, deps/PFCP ...................................................................... Patch Set 3: (3 comments) File library/PFCP_CodecPort_CtrlFunct.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/76f2f4d3_d395… PS1, Line 7: inout PFCP_PT portRef, Ack File library/PFCP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/bfea1ff6_5ca4… PS1, Line 18: type enumerated e_PFCP_Cause { I thought it was in our library/ dir, then it's fine you can keep it in Templates. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/1c12fe40_6612… PS1, Line 418: function ts_PFCP_Session_Est_Req(charstring node_id, OCT8 cp_seid, Create_PDR_list create_pdr, Create_FAR_list create_far) return template PDU_PFCP { marking as (value) means you cannot pass a template containing a field which is not set to a value, aka ? or *, which means the compiler shouldn't allow you passing a tr_ template in there. Similarly, (present) prevents people from passing omit to a function not expecting it. Furthermore, it clarifies to the reader what is expected to be passed there. This kinda "nullable" mark some languages have, which allows knowing whether passing a null pointer is accepted or not. Having correct restrictions properly written also translate to work hours spent by all others. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f Gerrit-Change-Number: 28817 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Aug 2022 09:38:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment