Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33692 )
Change subject: pySim/cards: Add type annotations ......................................................................
Patch Set 4:
(4 comments)
File pySim/cards.py:
https://gerrit.osmocom.org/c/pysim/+/33692/comment/80e2a8d3_a48aa915 PS4, Line 39: reset
Missing return type annotation. Something like `-> Optional[... […]
Done
https://gerrit.osmocom.org/c/pysim/+/33692/comment/33ef514c_ab1c41cd PS4, Line 47: set_apdu_parameter
Functions returning nothing should be annotated as such using `-> None`.
thanks, didn't know that and I think never did that anywhere so far.
https://gerrit.osmocom.org/c/pysim/+/33692/comment/3af71635_868c1cde PS4, Line 124: Hexstr
`-> Optional[Hexstr]`
Done
https://gerrit.osmocom.org/c/pysim/+/33692/comment/8c539bb2_7e9e9481 PS4, Line 134: Hexstr
`-> Optional[Hexstr]`
Done