Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email )
Change subject: Add TCAP based loadsharing/routing ......................................................................
Patch Set 8:
(4 comments)
File src/ss7_as.h:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/4fad13b2_58f54c... : PS8, Line 6: #include <osmocom/core/hashtable.h>
#ifdef WITH_TCAP_LOADSHARING
Does the include hurt? I would try to prevent cluttering #ifdefs everywhere.
File src/ss7_as.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/7db15e8e_cb9518... : PS8, Line 545: case OSMO_SS7_AS_TMOD_LOADSHARE:
#ifdef WITH_TCAP_LOADSHARING […]
This is fine.
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/c09cd7a6_106d84... : PS8, Line 634:
extra line not needed.
Acknowledged
File src/ss7_as_loadshare_tcap.h:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/048f1c72_280215... : PS8, Line 14: #ifdef WITH_TCAP_LOADSHARING
YOu can remove this, simply don't even include it if not requested by configure...
No, I want to keep it here because of the #else branch.