Attention is currently required from: pespin.

View Change

4 comments:

• File src/ss7_as.h:

  • Patch Set #8, Line 6: #include <osmocom/core/hashtable.h>

    #ifdef WITH_TCAP_LOADSHARING

    Does the include hurt? I would try to prevent cluttering #ifdefs everywhere.

• File src/ss7_as.c:

  • Patch Set #8, Line 545: case OSMO_SS7_AS_TMOD_LOADSHARE:

    #ifdef WITH_TCAP_LOADSHARING […]

    This is fine.

  • Patch Set #8, Line 634:

    extra line not needed.

    Acknowledged

• File src/ss7_as_loadshare_tcap.h:

  • Patch Set #8, Line 14: #ifdef WITH_TCAP_LOADSHARING

    YOu can remove this, simply don't even include it if not requested by configure...

    No, I want to keep it here because of the #else branch.

To view, visit change 41309. To unsubscribe, or for help writing mail filters, visit settings.