Attention is currently required from: fixeria, laforge, pespin.
keith has posted comments on this change by keith. (
https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email )
Change subject: Fix missing LAC/CI hashtable update upon CTRL SET
......................................................................
Patch Set 8: Verified+1
(1 comment)
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/1dbf6cb0_e4d54141?usp… :
PS6, Line 769: return
Done
Yeah, not that it matters, but other
similar functions seem to be defined as int and returned 0 unconditionally, so I just
followed suit.
Actually, in patch set 1, I did check the return value (at least from the vty) - yes,
assuming maybe in the future we may not return 0, but due to warnings about control
reaching end of non void function, I thought it was better to just remove the check for
return value rather than checking it, returning OK and then returning OK anyway.. seemed
more ugly, anyway.. They are void now so all good for the time being.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861
Gerrit-Change-Number: 40917
Gerrit-PatchSet: 8
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Aug 2025 18:24:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>