Attention is currently required from: fixeria, laforge, pespin.

Patch set 8:Verified +1

View Change

1 comment:

• File src/osmo-bsc/bts.c:

  • Patch Set #6, Line 769: return

    Done

    Yeah, not that it matters, but other similar functions seem to be defined as int and returned 0 unconditionally, so I just followed suit.

    Actually, in patch set 1, I did check the return value (at least from the vty) - yes, assuming maybe in the future we may not return 0, but due to warnings about control reaching end of non void function, I thought it was better to just remove the check for return value rather than checking it, returning OK and then returning OK anyway.. seemed more ugly, anyway.. They are void now so all good for the time being.

To view, visit change 40917. To unsubscribe, or for help writing mail filters, visit settings.