Attention is currently required from: fixeria, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28914 )
Change subject: abis_om2000: move switch-case to function ......................................................................
Patch Set 2:
(4 comments)
File src/osmo-bsc/abis_om2000.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/9d616c3e_a8adb091 PS1, Line 964: oml_avstate_from_om2k_mostate
static?
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/6e594a99_5be912e9 PS1, Line 997: switch (mo->class) {
You can probably move this inside oml_avstate_from_om2k_mostate() too, and pass mo->class there as a […]
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/4e50cb90_dd571a7b PS1, Line 1016: oml_opstate_from_om2k_opstate
static?
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/8d93e84e_3d5f657d PS1, Line 1016: enum abis_nm_op_state oml_opstate_from_om2k_opstate(uint8_t op_state)
it's a bit strange that a function starting with "oml_opstate" returns a "abis_nm_op_state" don't yo […]
I am not sure about the naming scheme. "abis" is one layer below. As far as I understand om2k is also on top of abis. The real difference is between OM2K and OML.
Du you have a suggestion for a better function name?