15 Apr
2024
15 Apr
'24
4:53 p.m.
Attention is currently required from: fixeria.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36455?usp=email )
Change subject: msc: f_expect_paging(): fix by_tmsi arg
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File msc/BSC_ConnectionHandler.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36455/comment/8a4a445f_89f0…
PS3, Line 1371: f_expect_paging_tmsi(g_pars.tmsi);
These patches are not getting better IMHO, and also there is no practical benefit in
getting this perfect.
What's still weird here:
- say there is a g_pars.tmsi set, but a test case wants to explicitly expect a paging
without TMSI (maybe just for failing fast on the wrong response), then to NOT have a TMSI
in the template, i have to call f_expect_paging_tmsi(). That's kind of weird, right?
- the RANAP part doesn't match the TMSI arguments well, since there is no TMSI
involved.
I think none of the patch sets (including mine) really nails it, and I *still* think the
originally submitted boolean argument is simplest, least confusing way here.
f_expect_paging(by_tmsi := false)
But let's get over this and just merge it, shall we?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36455?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9434745b7faeb738caafed8080b9f7b1a6a8079a
Gerrit-Change-Number: 36455
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 15 Apr 2024 14:53:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment