Attention is currently required from: fixeria.

Patch set 3:Code-Review +2

1 comment:

File msc/BSC_ConnectionHandler.ttcn:
- Patch Set #3, Line 1371: f_expect_paging_tmsi(g_pars.tmsi);
  These patches are not getting better IMHO, and also there is no practical benefit in getting this perfect.
  What's still weird here:
  - say there is a g_pars.tmsi set, but a test case wants to explicitly expect a paging without TMSI (maybe just for failing fast on the wrong response), then to NOT have a TMSI in the template, i have to call f_expect_paging_tmsi(). That's kind of weird, right?
  - the RANAP part doesn't match the TMSI arguments well, since there is no TMSI involved.
  I think none of the patch sets (including mine) really nails it, and I *still* think the originally submitted boolean argument is simplest, least confusing way here.
```
    f_expect_paging(by_tmsi := false)
    
But let's get over this and just merge it, shall we?
```

To view, visit change 36455. To unsubscribe, or for help writing mail filters, visit settings.