Change in pysim[master]: EF.AD: Avoid NotImplementedErrror regarding network names

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/28682 ) Change subject: EF.AD: Avoid NotImplementedErrror regarding network names ...................................................................... EF.AD: Avoid NotImplementedErrror regarding network names Even while we don't yet have a proper decoder, let's at least represent the network name as hex-string Change-Id: I4ed626699d1e4e484d4ffd04349676dadff626a0 --- M pySim/ts_51_011.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 0927c9f..7e7020b 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -878,11 +878,13 @@ class EF_PNN(LinFixedEF): class FullNameForNetwork(BER_TLV_IE, tag=0x43): # TS 24.008 10.5.3.5a - pass + # TODO: proper decode + _construct = HexAdapter(GreedyBytes) class ShortNameForNetwork(BER_TLV_IE, tag=0x45): # TS 24.008 10.5.3.5a - pass + # TODO: proper decode + _construct = HexAdapter(GreedyBytes) class NetworkNameCollection(TLV_IE_Collection, nested=[FullNameForNetwork, ShortNameForNetwork]): pass 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4ed626699d1e4e484d4ffd04349676dadff626a0 Gerrit-Change-Number: 28682 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged