laforge submitted this change.

View Change

Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved
EF.AD: Avoid NotImplementedErrror regarding network names

Even while we don't yet have a proper decoder, let's at least represent
the network name as hex-string

Change-Id: I4ed626699d1e4e484d4ffd04349676dadff626a0
---
M pySim/ts_51_011.py
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py
index 0927c9f..7e7020b 100644
--- a/pySim/ts_51_011.py
+++ b/pySim/ts_51_011.py
@@ -878,11 +878,13 @@
class EF_PNN(LinFixedEF):
class FullNameForNetwork(BER_TLV_IE, tag=0x43):
# TS 24.008 10.5.3.5a
- pass
+ # TODO: proper decode
+ _construct = HexAdapter(GreedyBytes)

class ShortNameForNetwork(BER_TLV_IE, tag=0x45):
# TS 24.008 10.5.3.5a
- pass
+ # TODO: proper decode
+ _construct = HexAdapter(GreedyBytes)

class NetworkNameCollection(TLV_IE_Collection, nested=[FullNameForNetwork, ShortNameForNetwork]):
pass

1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.

To view, visit change 28682. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4ed626699d1e4e484d4ffd04349676dadff626a0
Gerrit-Change-Number: 28682
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-MessageType: merged