Attention is currently required from: laforge, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email )
Change subject: per-HNB GTP-U traffic counters via nft ......................................................................
Patch Set 8:
(10 comments)
File include/osmocom/hnbgw/hnbgw.h:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/05db6881_c2e313de PS6, Line 384: /* When rules to count traffic to and from this hNodeB are present, this reflects the state in nftables
"rules" and "nftables rules" is the same thing. […]
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/e4f7363b_9d5f1f5c PS6, Line 446: bool enable;
nft_kpi.enable means nft_kpi is enabled, […]
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/7c5eace2_0b14116a PS6, Line 483: struct {
I'm not a friend of comments like […]
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/b6ed9449_5b8dd6c6 PS6, Line 514: void hnb_persistent_connected(struct hnb_persistent *hnbp);
(not sure i understand what you mean by stack level) […]
Done
File include/osmocom/hnbgw/nft_kpi.h:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/e166bad6_f8e42919 PS6, Line 7: struct nft_kpi_handle {
i can explain in a comment that nftables has "handles" required to remove unnamed rules... […]
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/2d7fa26e_8c21e836 PS6, Line 19: void nft_kpi_hnb_persistent_init(struct hnb_persistent *hnbp);
ah yes, i had names based on "init the ruleset" at some point, this is a leftover. […]
Done
File src/osmo-hnbgw/hnbgw.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/78f44e93_2a1bdebb PS6, Line 590: if (osmo_sockaddr_str_from_osa(&remote_str, &osa)) {
yes
Done
File src/osmo-hnbgw/hnbgw_vty.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/35175add_26566ad4 PS6, Line 899: g_hnbgw->config.nft_kpi.table_name = talloc_strdup(g_hnbgw, set_table_name);
yup, it incrementally became this so i didn't notice, thx
Done
File src/osmo-hnbgw/nft_kpi.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/597df748_1c4a4942 PS6, Line 18: #include <inttypes.h>
hm i thought i had that somewhere...
Done
File tests/osmo-hnbgw.vty:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/8718a2e4_077d62c7 PS6, Line 96: bw
haha no-one found this typo!
Done