Attention is currently required from: laforge, pespin.
10 comments:
File include/osmocom/hnbgw/hnbgw.h:
Patch Set #6, Line 384: /* When rules to count traffic to and from this hNodeB are present, this reflects the state in nftables
"rules" and "nftables rules" is the same thing. […]
Done
Patch Set #6, Line 446: bool enable;
nft_kpi.enable means nft_kpi is enabled, […]
Done
Patch Set #6, Line 483: struct {
I'm not a friend of comments like […]
Done
Patch Set #6, Line 514: void hnb_persistent_connected(struct hnb_persistent *hnbp);
(not sure i understand what you mean by stack level) […]
Done
File include/osmocom/hnbgw/nft_kpi.h:
Patch Set #6, Line 7: struct nft_kpi_handle {
i can explain in a comment that nftables has "handles" required to remove unnamed rules... […]
Done
Patch Set #6, Line 19: void nft_kpi_hnb_persistent_init(struct hnb_persistent *hnbp);
ah yes, i had names based on "init the ruleset" at some point, this is a leftover. […]
Done
File src/osmo-hnbgw/hnbgw.c:
Patch Set #6, Line 590: if (osmo_sockaddr_str_from_osa(&remote_str, &osa)) {
yes
Done
File src/osmo-hnbgw/hnbgw_vty.c:
Patch Set #6, Line 899: g_hnbgw->config.nft_kpi.table_name = talloc_strdup(g_hnbgw, set_table_name);
yup, it incrementally became this so i didn't notice, thx
Done
File src/osmo-hnbgw/nft_kpi.c:
Patch Set #6, Line 18: #include <inttypes.h>
hm i thought i had that somewhere...
Done
File tests/osmo-hnbgw.vty:
haha no-one found this typo!
Done
To view, visit change 36539. To unsubscribe, or for help writing mail filters, visit settings.