Attention is currently required from: daniel, pespin.
osmith has posted comments on this change by osmith. (
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email )
Change subject: Regenerate code with newer asn1c
......................................................................
Patch Set 4:
(4 comments)
File include/AARE-apdu.h:
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/a1e0d410_98d…
:
PS3, Line 1: /*
This library instead sets […]
Done
File include/Makefile.am:
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/4c7f0c8e_0b4…
:
PS3, Line 1: osmo_asn1_tcap_HEADERS = \
Missing (see
osmo-cbc.git/include/osmocom/sbcap/Makefile.am): […]
this gets added in a later
patch:
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41027/4
File src/Makefile.am:
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/c3526dfe_698…
:
PS3, Line 9: libosmo_asn1_tcap_la_SOURCES = \
IMHO this file should be doing stuff like
osmo-cbc/src/sbcap/Makefile.am.
Done
File src/constr_CHOICE_print.c:
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/3c2b2a3a_c5f…
:
PS3, Line 1: /*
Yes, but still it makes sense to have them in well
known separate directory. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: If43a5d518f94fa558a3dff563a1c7aa31c925fec
Gerrit-Change-Number: 41022
Gerrit-PatchSet: 4
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Sep 2025 13:22:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>