Attention is currently required from: daniel, pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email )
Change subject: Regenerate code with newer asn1c ......................................................................
Patch Set 4:
(4 comments)
File include/AARE-apdu.h:
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/a1e0d410_98d4... : PS3, Line 1: /*
This library instead sets […]
Done
File include/Makefile.am:
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/4c7f0c8e_0b49... : PS3, Line 1: osmo_asn1_tcap_HEADERS = \
Missing (see osmo-cbc.git/include/osmocom/sbcap/Makefile.am): […]
this gets added in a later patch: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41027/4
File src/Makefile.am:
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/c3526dfe_6982... : PS3, Line 9: libosmo_asn1_tcap_la_SOURCES = \
IMHO this file should be doing stuff like osmo-cbc/src/sbcap/Makefile.am.
Done
File src/constr_CHOICE_print.c:
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/3c2b2a3a_c5fe... : PS3, Line 1: /*
Yes, but still it makes sense to have them in well known separate directory. […]
Done