Attention is currently required from: daniel, pespin.

View Change

4 comments:

• File include/AARE-apdu.h:

  • Patch Set #3, Line 1: /*

    This library instead sets […]

    Done

• File include/Makefile.am:

  • Patch Set #3, Line 1: osmo_asn1_tcap_HEADERS = \

    Missing (see osmo-cbc.git/include/osmocom/sbcap/Makefile.am): […]

    this gets added in a later patch: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41027/4

• File src/Makefile.am:

  • Patch Set #3, Line 9: libosmo_asn1_tcap_la_SOURCES = \

    IMHO this file should be doing stuff like osmo-cbc/src/sbcap/Makefile.am.

    Done

• File src/constr_CHOICE_print.c:

  • Patch Set #3, Line 1: /*

    Yes, but still it makes sense to have them in well known separate directory. […]

    Done

To view, visit change 41022. To unsubscribe, or for help writing mail filters, visit settings.