Attention is currently required from: laforge, fixeria, dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/28678 )
Change subject: trxcon: support handling of multiple L1CTL client connections
......................................................................
Patch Set 6:
(3 comments)
File src/host/trxcon/src/l1ctl_server.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28678/comment/d71e122a_65dfae92
PS6, Line 55: "L1CTL server has lost connection (id=%u)\n",
looks like you want to print id inside LOGP_CLI directly, not here.
https://gerrit.osmocom.org/c/osmocom-bb/+/28678/comment/6eb95797_0d7bfe1e
PS6, Line 163: client->id = server->client_id_seed++;
so this misteriours "seed" is actually "next_client_id". Having it
named that way like we usually do would make it a lot clearer.
https://gerrit.osmocom.org/c/osmocom-bb/+/28678/comment/b02d8b4c_b6c1090f
PS6, Line 167: LOGP(DL1C, LOGL_NOTICE, "L1CTL server got a new connection
(id=%u)\n", client->id);
Use LOGP_CLI
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/28678
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Id92e5b553487e4cf10ea291b487a3ef0c65d72ae
Gerrit-Change-Number: 28678
Gerrit-PatchSet: 6
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Jul 2022 08:57:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment