Attention is currently required from: laforge, fixeria, dexter.

View Change

3 comments:

• File src/host/trxcon/src/l1ctl_server.c:

  • Patch Set #6, Line 55: "L1CTL server has lost connection (id=%u)\n",

    looks like you want to print id inside LOGP_CLI directly, not here.

  • Patch Set #6, Line 163: client->id = server->client_id_seed++;

    so this misteriours "seed" is actually "next_client_id". Having it named that way like we usually do would make it a lot clearer.

  • Patch Set #6, Line 167: LOGP(DL1C, LOGL_NOTICE, "L1CTL server got a new connection (id=%u)\n", client->id);

    Use LOGP_CLI

To view, visit change 28678. To unsubscribe, or for help writing mail filters, visit settings.