Attention is currently required from: dexter, pespin.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/34648?usp=email )
Change subject: pcuif_proto: signal BTS model via PCUIF
......................................................................
Patch Set 5:
(3 comments)
File src/common/pcu_sock.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11899):
https://gerrit.osmocom.org/c/osmo-bts/+/34648/comment/f1fd686e_a00a520b
PS5, Line 235: static enum gsm_pcuif_bts_model bts_model_from_variant(enum
gsm_bts_type_variant variant) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11899):
https://gerrit.osmocom.org/c/osmo-bts/+/34648/comment/1d157c99_3a657f80
PS5, Line 246: - case BTS_OSMO_VIRTUAL:
space prohibited after that '-' (ctx:ExW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11899):
https://gerrit.osmocom.org/c/osmo-bts/+/34648/comment/1f563543_5d2f1507
PS5, Line 247: return PCU_IF_BTS_MODEL_TRX;
code indent should use tabs where possible
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/34648?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib51238a0e09d4484a539a7f822864189872698b6
Gerrit-Change-Number: 34648
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Oct 2023 08:13:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment